Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review size limits #266

Open
vinniefalco opened this issue Jul 28, 2022 · 3 comments
Open

review size limits #266

vinniefalco opened this issue Jul 28, 2022 · 3 comments
Labels
Design Design input needed

Comments

@vinniefalco
Copy link
Member

Without the table we could use a larger bit width for off_t. And we should review every function to make sure it respects the size limits. Te refactoring of the top level rfc rules may have invalidated existing checks for limits.

@vinniefalco
Copy link
Member Author

I removed checks for max_size

@alandefreitas
Copy link
Member

We are just working with std::size_t now and off_t doesn't exist anymore. What's the state of this issue? Does it still make sense?

@vinniefalco
Copy link
Member Author

I'm pretty sure there are a few loose ends where we don't correctly check for overflow when performing unsigned arithmetic. I tried to get edit_segments and edit_params right, maybe you want to look at them and see if they are correct and sufficiently tested?

@alandefreitas alandefreitas added the Design Design input needed label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design input needed
Projects
None yet
Development

No branches or pull requests

2 participants