Please send a PR, this is the only way to fix the issue

Hi! Feel free to send a PR :)

Just one thing: if you take a look at the CSVIterator::rewind method for instance:

    /**
     * Rewind the Iterator to the first element
     * @see http://php.net/manual/en/iterator.rewind.php
     *
     * @return void
     */
    public function rewind()
    {
        ...
    }

As you can see, the PHPDoc is correct. To solve the issue you mentioned, the correct fix would be to add a proper return type (instead of adding the #[\ReturnTypeWillChange] attribute).

As you can see, the PHPDoc is correct. To solve the issue you mentioned, the correct fix would be to add a proper return type (instead of adding the #[\ReturnTypeWillChange] attribute).

Adding the return type would break backward compatibility and assuming that this fix would get released as a patch version, I am not sure this would be the best solution. If this is not a concern, however, I can certainly PR accordingly.

Well most of the methods are (or should be considered) internal only. So adding a return type should not break anybody.
Also, the @return in the PHPDocs should be correct. So the only case where it's going to break something is if someone used an internal method that did not have the correct type.
Is that correct?

Well most of the methods are (or should be considered) internal only. So adding a return type should not break anybody.
Also, the @return in the PHPDocs should be correct. So the only case where it's going to break something is if someone used an internal method that did not have the correct type.
Is that correct?

Well, you could get a break even with a correct return type because adding explicit return types forces all extending classes to have explicit return types as well, otherwise PHP will raise a fatal error (function interface mismatch).
So if the RowIterator::rewind() function interface were changed to

class RowIterator implements IteratorInterface
{
    /**
     * Rewind the Iterator to the first element
     * @see http://php.net/manual/en/iterator.rewind.php
     */
    public function rewind(): void
    {
        ...
    }
}

then an overridden function with the current interface in an extending class

class MyIterator extends RowIterator
{
    /**
     * Rewind the Iterator to the first element
     * @see http://php.net/manual/en/iterator.rewind.php
     *
     * @return void
     */
    public function rewind()
    {
        ...
    }
}

would cause a break.

Please let me know whether you prefer the addition of explicit return types (despite possible breaks) or want it to be solved with attributes.

@fabacino As part of another PR, I fixed these issues (using explicit types)