Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/NIGHTLY] Nala icons have been replaced by the chromium ones #38355

Closed
TheAresjej opened this issue May 15, 2024 · 4 comments
Closed

[UI/NIGHTLY] Nala icons have been replaced by the chromium ones #38355

TheAresjej opened this issue May 15, 2024 · 4 comments
Labels
closed/duplicate Issue has already been reported

Comments

@TheAresjej
Copy link

Description

Nala icons have been replaced by the default ones from chromium. 馃檨

Actual result:

Extensions icon (main UI)
image

Settings icon (extensions menu)
image

Clear Browsing Data icon (brave://settings/privacy)
image

Expected result:

Icons should again use the Brave style.

Brave version (brave://version info)

Version 1.68.19 Chromium: 125.0.6422.41 (Official Build) nightly (x86_64)
@bsclifton bsclifton added the design A design change, especially one which needs input from the design team label May 16, 2024
@bsclifton
Copy link
Member

cc: @fallaciousreasoning @zenparsing

@zenparsing
Copy link

Likely due to https://chromium-review.googlesource.com/c/chromium/src/+/5444096.

One solution would be to add an override to leo_overrides.json for kExtensionChromeRefreshIcon:

"//components/vector_icons/extension_chrome_refresh.icon": "leo_browser_extensions",

@rebron
Copy link
Collaborator

rebron commented May 16, 2024

@zenparsing Dupe of #37583?

@rebron rebron added this to Untriaged backlog in Front End May 16, 2024
@bsclifton
Copy link
Member

@rebron yeah I think we can club it into that one. I'll close this out and put a note in #37583

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label May 20, 2024
@bsclifton bsclifton mentioned this issue May 20, 2024
Open
@rebron rebron removed this from Untriaged backlog in Front End May 21, 2024
@rebron rebron removed design A design change, especially one which needs input from the design team OS/Desktop labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bsclifton @rebron @zenparsing @TheAresjej