Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] General housekeeping #23695

Merged
merged 1 commit into from
May 17, 2024
Merged

[ads] General housekeeping #23695

merged 1 commit into from
May 17, 2024

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 16, 2024

Resolves brave/brave-browser#38366

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey self-assigned this May 16, 2024
@tmancey tmancey force-pushed the issues/38366 branch 4 times, most recently from abba732 to dfc0c0a Compare May 16, 2024 14:15
@tmancey tmancey marked this pull request as ready for review May 17, 2024 01:01
@tmancey tmancey requested a review from a team as a code owner May 17, 2024 01:01
@tmancey tmancey force-pushed the issues/38366 branch 5 times, most recently from 8579887 to a843382 Compare May 17, 2024 16:10
@tmancey tmancey force-pushed the issues/38366 branch 3 times, most recently from 7332d46 to c8b9c7b Compare May 17, 2024 19:56
@github-actions GitHub Actions
Copy link
Contributor

[puLL-Merge] - brave/brave-core@23695

Here is the review of the pull request:

Description

This PR makes various changes across the Brave Ads codebase, including:

  • Renaming some methods to start with "Maybe" to better reflect optional return values
  • Changing some feature checks from using vectors to using initializer lists
  • Fixing some IWYU pragmas
  • Changing some tests to check the returned optional directly rather than just asserting true/false
  • Renaming some tests for better clarity
  • Minor code cleanup and simplifications

The motivation seems to be general code quality improvements and better adherence to Brave coding standards.

Changes

Changes

brave_ads/browser:

  • Rename GetPrefetchedNewTabPageAdForDisplay to MaybeGetPrefetchedNewTabPageAdForDisplay
  • Rename GetPath to MaybeGetPath
  • Mark MigrateToV38 as static

brave_ads/core/internal:

  • Rename some "disabled" terminology in tests to "opted out"
  • Mark some migration methods as static
  • Move page_land_user_data to a new location under account/user_data/fixed
  • Remove unused build_user_data_callback.h
  • Change some feature setup to use initializer lists instead of vectors
  • Rename GetVisible to MaybeGetVisible for better optional semantics
  • Check locale pointer directly against nullptr
  • Simplify some pipeline tests to check optional directly
  • Remove some unused includes
  • Rename "disabled" terminology to "opted out" in various tests

brave_ads/core/test:

  • Update test BUILD file for new page_land_user_data location

ntp_background_images:

  • Update mock method name to MaybeGetPrefetchedNewTabPageAdForDisplay

Overall, the changes look good for improving code quality and readability. No major functionality changes. The renames to use "Maybe" are a good improvement for methods returning optionals.

@tmancey tmancey enabled auto-merge May 17, 2024 21:19
@tmancey tmancey merged commit 82b4b54 into master May 17, 2024
19 checks passed
@tmancey tmancey deleted the issues/38366 branch May 17, 2024 21:19
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseren aseren aseren approved these changes

Assignees

@tmancey tmancey

Labels
puLL-Merge
Projects
None yet
Milestone
1.68.x - Nightly
2 participants
@tmancey @aseren