Approving transaction without internet does not remove submitting / loading overlay

[StephenHeaps]

Description:

On iOS there is a transaction status overlay on Transaction Confirmation after a user taps Approve, until they tap 'ok' to either dismiss or show the next transaction in queue. More details: brave/brave-ios#6861

While a transaction is moving from unapproved to submitted/error/dropped status, there is currently no way to hide this overlay (without dismissing entire transaction confirmation modal).

When approving a transaction without an internet connection, this 'Submitting' overlay is not removed, but if you dismiss entire Transaction Confirmation and check Activity tab you can see the transaction is in error status.

Steps to Reproduce

1. Create a transaction on any network. Used ethereum for testing but should work for any transaction.
2. In Transaction Confirmation panel, wait for data to load
3. Once data has loaded, disable network connection
4. Tap approve
5. Loading spinner will not be removed from transaction. Dismiss transaction confirmation and open activity tab, observe transaction has error status

Actual result:

RPReplay_Final1715871159.MP4

Expected result:

Transaction should show error status after the loading spinner screen in Transaction Confirmation

Reproduces how often:

Easily reproduced

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight?
• Can you reproduce this issue with the previous version of the current build from TestFlight?
• Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

CC @srirambv thanks for reporting 👍

[kjozwiak]

The above requires 1.67.98 or higher for 1.67.x verification 👍