Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn the sample apps into Typesafe Activator templates #23

Open
brikis98 opened this issue Jul 10, 2015 · 2 comments
Open

Turn the sample apps into Typesafe Activator templates #23

brikis98 opened this issue Jul 10, 2015 · 2 comments

Comments

@brikis98
Copy link
Owner

The only catch is that Activator expects the activator.properties file in the root of your SBT project, so when SBT runs, it'll fire up the default project, which for ping-play is the aggregate rootProject and not the sample apps. Is it possible to have two activator.properties files, one in each sample app, even though the build details are in the directory above?

@LeonhardtDavid
Copy link
Contributor

Maybe I don't understand completely the settings on build.sbt, but it's necessary that the sample projects be sub projects?

I understand, like it is now, the dependencies are always updated. But, I think it is no possible to generate activator template in this case.

I'm not very familiarized with creating task on sbt and all the possibilities, would be feasible to have a task to update dependencies on sample projects on compile or publish?

@brikis98
Copy link
Owner Author

They are sub projects so that a) their dependencies are packaged separately so that including the ping-play jar in an app doesn't pull in a bunch of sample code and b) hot reload works across the sample apps and ping-play itself, so if I change some BigPipe code, I can just refresh the page in a sample app and see the update immediately.

I'm fairly confident the project is structured in a fairly idiomatic way for SBT. It's activator that (I think) makes the assumption that the root SBT project is the one you want. If i was possible to specify a custom sub-project for activator, or to put the .properties file in the subprojects themselves, we'd be in business.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants