[Need investigation] Huge memory leak?

[kikuomax]

. Is there a way for us to test that?

@kikuomax Good that you pointed that out. Yes, actually we use Memlab to gauge heap size and memory leaks in applications. Memlab requires us to write a scenario file as mentioned in their documentation. I created a scenario file for this project as well. Sadly currently memlab has a limitation of a protocolTimeout error for some cases, this one falls into that. I have reported the issue, they are working to fix within this week. After that I will attach the memory footprint results before and after the leak fixes in this project.

I have reported the issue, they are working to fix within this week.

I heard back from Memlab developer regarding the timeout and page crash issue I was facing when executing their tool on the scenario file I wrote for Buefy.

This is what their developer has to say:

My guess is that either 1) 1.4GB of memory is too much for Chrome to capture the heap snapshot (you could try taking the 1.4GB heap snapshot manually in Chrome DevTools to see if the Browser DevTools times out) or 2) the connection between Puppeteer and Chrome was not designed to handle such a large heap snapshot.

Moreover, if a web app uses more than 1GB JS heap, it has some serious memory issues. I would recommend testing on a scenario where the memory leak is less severe.

The code patterns fixed in this PR are some of the common sources of memory leaks, as per our research on Github and StackOverflow history. Nevertheless, if I manage to resolve the Memlab crash issue and provide concrete heap/leak reduction after these fixes, I will let you know as soon as is possible..

What kind of scenario are you running?

TBH It's a pretty normal scenario file that follows puppeteer syntax, similar to what I have been using for multiple other projects 🤔 . I have attached it here for reference:

test-scenario-buefy.js.zip

Originally posted by @Arooba-git in #3991 (comment)