Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes embedded member integration example #195

Open
derekperkins opened this issue Dec 19, 2022 · 4 comments
Open

kubernetes embedded member integration example #195

derekperkins opened this issue Dec 19, 2022 · 4 comments

Comments

@derekperkins
Copy link
Contributor

After poking around for a while, I ended up bypassing olric-cloud-plugin because it has compile errors with newer dependencies, plus bringing in hashicorp/go-discover really bloated our dependencies, when we are only interested in k8s. I just implemented the olric service discovery interface using k8s/client-go, and it works great in my limited testing. Here's a link to the gist, and I'm happy to contribute a PR with the example, but I wasn't sure if it made sense here, or if you were hoping to keep this in the cloud plugin repo.

https://gist.github.com/derekperkins/8f5232d897ccf5a20691a1556574cfce

@derekperkins derekperkins changed the title kubernetes embedded member integration kubernetes embedded member integration example Dec 19, 2022
@buraksezer
Copy link
Owner

Hey @derekperkins

Thank you for your contribution. I think we can publish your code snippet in the Olric repository. We may create a docs folder and add this kind of snippets there.

go-discovery is really bloated and I consider forking it and removing the least used pieces. Possibly, Kubernetes, GCE, and EC2 support should be enough.

@luisdavim
Copy link

Having a docs folder with all the examples would be nice.
We could even include how to setup olrid in a K8s deployment to be used as a server with other languages.

@luisdavim
Copy link

@derekperkins why not just use a headless service and DNS?

@derekperkins
Copy link
Contributor Author

I think originally I was expecting this to work more like a watch, so it would respond faster via the api, but it's probably just as effective and much simpler to use a headless service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants