Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Top Level view or Tree view #267

Open
kenbankspeng opened this issue Feb 21, 2024 · 6 comments
Open

Feature: Top Level view or Tree view #267

kenbankspeng opened this issue Feb 21, 2024 · 6 comments
Labels
Enhancement New feature or request

Comments

@kenbankspeng
Copy link

Feature Suggestion

Mandatory Information

Description
Cork provides a flat 'brew list' view of the installed packages. This certainly is needed. But I suggest users are most interested in the top level packages they installed. The sub-packages that were installed as part of the formula are just technical details.

Consider a simple Top Level view filter, or even better, a Tree view.

  1. Top Level view
    This is just a filter selection to only view the top level packages (leaves) in your flat package view.
    cli equivalent: brew leaves | xargs brew list --versions

  2. Tree view
    This would show the packages in a tree hierarchy similar to a folder/file tree. Users could drill into the sub-package details as needed.
    cli equivalent: brew deps --tree --installed

Type
UI

Mockups
No

@kenbankspeng kenbankspeng added the Enhancement New feature or request label Feb 21, 2024
@kenbankspeng
Copy link
Author

I now see you have a setting to view all packages or only manually installed. I suggest this be a filter button in the UI either embedded within your search box component or placed right beside it.

The Tree view would be the ultimate, but would take more work.

@buresdv
Copy link
Owner

buresdv commented Feb 27, 2024

Thanks for the idea. The filtering of packages installed intentionally using a search filter is already implemented, but the search filters don't show up due to a SwiftUI bug caused by Apple. See #191, which tracks this problem.

The tree view is currently way above my programming abilities, but I might revisit it in the future

@mrvincenzo
Copy link

mrvincenzo commented May 10, 2024

Show leaves as @kenbankspeng suggested would be great. Personally, I care about the top level dependencies installed (brew leaves). I care less about the dependencies of my leaves' dependencies I installed. Also, showing all formulaes is not optimal as the user can try to uninstall a dependency of a leaf dependency, which will result in broken leaf dependency.

@buresdv
Copy link
Owner

buresdv commented May 10, 2024

@mrvincenzo how relevant is this issue for you? #247

@mrvincenzo
Copy link

mrvincenzo commented May 10, 2024

@mrvincenzo how relevant is this issue for you? #247

It is close but it shows more formulaes than i see when running brew leaves, formalaes that i didn't installed directly

@buresdv
Copy link
Owner

buresdv commented May 10, 2024

brew leaves actually tends to leave some packages out from a ton of testing I did back when this feature was first implemented. Cork checks the metadata of the package directly, so it tends to be more accurate on average.

It only becomes a bigger problem if you manually modify a package that you haven't installed manually. At that point, it start being considered "manually modified", which gives it the same status as other packages you installed manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants