Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NeoForge] Deprecated mod file #4354

Open
Edouard127 opened this issue May 4, 2024 · 7 comments
Open

[NeoForge] Deprecated mod file #4354

Edouard127 opened this issue May 4, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Edouard127
Copy link

Edouard127 commented May 4, 2024

Information

Operating system: WIndows
Java version: 17.0.8
Minecraft version: 1.20.4
Baritone version: 1.10.2

Exception, error or logs

[09:47:28] [main/ERROR] (ModInfo) Mod 'baritoe' uses deprecated 'mandatory' field in the dependency declaration for 'minecraft'. Use the 'type' field and 'required'/'optional' instead
[09:47:28] [main/ERROR] (ModInfo) Mod 'baritoe' uses deprecated 'mandatory' field in the dependency declaration for 'minecraft'. Use the 'type' field and 'required'/'optional' instead

Aditionnal info

The deprecated field warning can be ignored in 1.20.4, but not in 1.20.5
NeoForge 20.5 introduced a neoforge.mods.toml metadata file that replaces the old mods.toml

https://neoforged.net/news/20.5release/

@Edouard127 Edouard127 added the bug Something isn't working label May 4, 2024
@ZacSharp ZacSharp mentioned this issue May 26, 2024
@ZacSharp
Copy link
Collaborator

This shouldn't be an issue on 1.20.4?
(The 1.20.5 port already renamed the file)

@ZacSharp
Copy link
Collaborator

ZacSharp commented Jun 2, 2024

@Edouard127 you reported this as a problem with 1.20.4 but as far as I can tell this is a 1.20.5+ change. Is 1.20.4 really affected?

@Edouard127
Copy link
Author

Edouard127 commented Jun 2, 2024

I don't think it will cause problems with previous versions
You cannot launch 1.20.4 with NeoForge 20.5

This is only a warning message for future versions

Maybe I launched with 1.20.5 and wrongly tagged the issue, I don't remember since It's been over a month
Edit: I launched the game in 1.20.4 neo 20.4.234 and I get the warning

@ZacSharp
Copy link
Collaborator

ZacSharp commented Jun 2, 2024

Ok, thank you.

@ZacSharp ZacSharp closed this as completed Jun 2, 2024
@ZacSharp ZacSharp reopened this Jun 2, 2024
@ZacSharp
Copy link
Collaborator

ZacSharp commented Jun 2, 2024

Timing... Just as I pressed close you edited you comment.

@ZacSharp
Copy link
Collaborator

ZacSharp commented Jun 2, 2024

"Fixing" this for 1.20.4 shouldn't be required but might just as well do it anyway.

@Edouard127 Edouard127 changed the title [NeoForge] Use of deprecated toml file [NeoForge] Deprecated mod file Jun 2, 2024
@Edouard127
Copy link
Author

I have edited the issue description to avoid further confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants