Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset validation failed - A key for 'MinimumOSVersion' is required #101

Open
billyjacoby opened this issue Feb 7, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@billyjacoby
Copy link

Description

Trying to validate a package gives the error:

Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle rnVision.app/ Frameworks/hermes.framework is required. (ID: 9433b1a0-5eff-4dd6-987b-06de7f96acca))

Steps to reproduce

  1. Install a new applicaiton
  2. Create an archive
  3. Validate that archive

React Native Version

0.73.3

Affected Platforms

Other (please specify)

Output of npx react-native info

System:
  OS: macOS 14.4
  CPU: (10) arm64 Apple M1 Max
  Memory: 6.48 GB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.18.2
    path: ~/.nvm/versions/node/v18.18.2/bin/node
  Yarn:
    version: 4.1.0
    path: ~/.nvm/versions/node/v18.18.2/bin/yarn
  npm:
    version: 9.8.1
    path: ~/.nvm/versions/node/v18.18.2/bin/npm
  Watchman:
    version: 2024.01.22.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.2 AI-222.4459.24.2221.9971841
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.19
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.3
    wanted: 0.73.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle rnVision.app/ Frameworks/hermes.framework is required. (ID: 9433b1a0-5eff-4dd6-987b-06de7f96acca))

Reproducer

https://github.com/billyjacoby/vision-template

Screenshots and Videos

I know this project is marked as experimental and not ready for production, but wanted to post these findings here anyway.

I tried adding the MinimumOSValue in the visionos/Pods/hermes-engine/destroot/Library/Frameworks/xros/hermes.framework/Info.plist file, but that didn't seem to help.

@okwasniewski
Copy link
Member

okwasniewski commented Feb 7, 2024

Hey, thanks for opening the issue. I'm aware of this bug and I have it on my todo list 😄

A workaround that you can do:

  1. Archive
  2. Click Open Archive in Finder
  3. Click "Show Package contents" on .xcarchive in Finder
  4. Go to Products/Applications/NameOfTheApp.app
  5. Click on the .app and "Show Package contents"
  6. Go to Frameworks/hermes.framework
  7. Modify the contents of Info.plist to include:
<key>MinimumOSVersion</key>
<string>1.0</string>

I think it may also work if you modify the destroot/Library/Frameworks one but with MinimumOSVersion

@okwasniewski okwasniewski added the bug Something isn't working label Feb 7, 2024
@billyjacoby
Copy link
Author

That workaround fixes it, thanks!

@okwasniewski
Copy link
Member

This issue should be closed once this PR gets merged to Hermes: facebook/hermes#1358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants