Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Refactor ChatAgent #526

Open
2 tasks done
Wendong-Fan opened this issue Apr 23, 2024 · 1 comment
Open
2 tasks done

[Feature Request] Refactor ChatAgent #526

Wendong-Fan opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Wendong-Fan
Copy link
Member

Wendong-Fan commented Apr 23, 2024

Required prerequisites

Motivation

  1. current ChatAgent is redundant, we want to refactor this class to make it more tidy
  2. we need to support passing API Key as parameter into ChatAgent , this feature is required for the platform development
  3. remove ChatGPTVisionConfig , merge FunctionCallingConfig into ChatGPTConfig to make the abstraction tidy as discussed in feat: enable image modality for ChatAgent #473

Solution

  1. Separate initialization of model and chat agent
  2. model_type ,model_config ,message_window_size,token_limit move to model
  3. move def handle_batch_response and def handle_stream_response from chat agent to model
  4. add config folder, set model config based on framework done by Zecheng
  5. Model.create(platform='', model='',...)

Alternatives

No response

Additional context

No response

@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Apr 23, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 2 milestone Apr 23, 2024
@Wendong-Fan Wendong-Fan self-assigned this Apr 23, 2024
@Wendong-Fan Wendong-Fan changed the title [Feature Request] API Key as parameter into ChatAgent [Feature Request] Refactor ChatAgent Apr 23, 2024
@Wendong-Fan
Copy link
Member Author

Wendong-Fan commented Apr 23, 2024

@ocss884 @zechengz feel free to add content into this issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Sprint Planned
Development

No branches or pull requests

3 participants