Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operation and applier for disabling exporter #18418

Closed
Tracked by #18030
deepthidevaki opened this issue May 10, 2024 · 0 comments · Fixed by #18426
Closed
Tracked by #18030

Add operation and applier for disabling exporter #18418

deepthidevaki opened this issue May 10, 2024 · 0 comments · Fixed by #18426
Assignees
@deepthidevaki
Labels
component/zeebe Related to the Zeebe component/team kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented May 10, 2024 •
edited

To make changes to the state of the exporter to disabled, an operation must be added to the ClusterChangePlan. The operation will be applied by the ClusterConfigurationManager similar to other configuration change operations.

  1. Add a ConfigurationChangeOperation for disabling the exporter in a partition in a broker
  2. Add an applier that can apply this operation and change the state of the exporter.
@deepthidevaki deepthidevaki mentioned this issue May 10, 2024
Closed
@deepthidevaki deepthidevaki added kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue scope/broker Marks an issue or PR to appear in the broker section of the changelog component/zeebe Related to the Zeebe component/team labels May 10, 2024
@deepthidevaki deepthidevaki self-assigned this May 10, 2024
@deepthidevaki deepthidevaki mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@npepinpe
Add operation and applier for disabling exporter (#18426)
1205b37 
## Description

This PR adds a new `PartitionDisabledExporterOperation` to the allowed
list of configuration change operations. An operation applier is also
added which can delegate the operation to the `PartitionManager` and
updates the configuration after the exporter is disabled. The operation
will be applied by `ClusterConfigurationManager` similar to all other
configuration change operation.

When a new operation is added, we also have to define it in the open-api
spec for cluster endpoint. To simplify this, this PR also adds an
`UNKNOWN` operation as a catch-all for all unimplemented operations. A
proper response will be defined later when the gateway endpoint for
disabling exporter will be added.

## Related issues

closes #18418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
component/zeebe Related to the Zeebe component/team kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add operation and applier for disabling exporter camunda/camunda
1 participant
@deepthidevaki