Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support REVISION_TIME #2155

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 19, 2024

Summary

The general story behind this is outlined in #2153 - ultimately, this has Capistrano start to manage a REVISION_TIME file which holds a unix timestamp of when the release was committed, in the same way that it stores that releases SHA in REVISION.

Resolves #2153

Short checklist

  • Did you run bundle exec rubocop -a to fix linter issues?
  • If relevant, did you create a test?
  • Did you confirm that the RSpec tests pass?

Other Information

I think this is actually pretty close to being landable since I figured out the general "how" a while ago in another project, but I expect some tweaking will probably be required and it would be nice to support this for svn and hg if possible but I don't use those tools so will either need someone who does to provide insight or I'll see if I can google/chatgpt a solution.

Some general questions I have are:

  • do we want to have a dedicated set of tasks, or fold this into the current "revision" based ones?
  • in the context of custom SCMs, do we want to make this an optional extra or required?
  • if optional, do we need to have any custom/extra checks? (I noticed that there are some NotImplementedError methods but it didn't seem like they were actually being called by Capistrano itself)
  • if the revision time isn't available, do we want to create an REVISION_TIME file at all? (it'd be simpler, but an empty file)

@G-Rath G-Rath marked this pull request as ready for review May 20, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exposing revision time alongside revision sha (when using git)
2 participants