Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The general story behind this is outlined in #2153 - ultimately, this has Capistrano start to manage a
REVISION_TIME
file which holds a unix timestamp of when the release was committed, in the same way that it stores that releases SHA inREVISION
.Resolves #2153
Short checklist
bundle exec rubocop -a
to fix linter issues?Other Information
I think this is actually pretty close to being landable since I figured out the general "how" a while ago in another project, but I expect some tweaking will probably be required and it would be nice to support this for svn and hg if possible but I don't use those tools so will either need someone who does to provide insight or I'll see if I can google/chatgpt a solution.
Some general questions I have are:
NotImplementedError
methods but it didn't seem like they were actually being called by Capistrano itself)REVISION_TIME
file at all? (it'd be simpler, but an empty file)