refactor: converted index.js to index.ts for OverflowMenu
#16494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gururajj77
added
DO NOT MERGE
status: ready for review 👀
and removed
DO NOT MERGE
labels
riddhybansal
approved these changes
May 20, 2024
2nikhiltom
approved these changes
May 21, 2024
alisonjoseph
approved these changes
May 21, 2024
alisonjoseph
added
status: one more review 👀
and removed
status: ready to merge 🎉
labels
guidari
approved these changes
May 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
96ef1a3
20 checks passed
|
Hey there! v11.58.0 was just released that references this issue/PR. |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue: #16154
Closes #16444
Closes #16447 as part of exporting props for
OverflowmenuChanged from Index.js to Index.tsx as part of typescript adoption.
Changelog
New
Changed
OverflowMenuComponentastypeof React.Componentfor type assertionrenderIcon's type asComponentType<IconProps>Offsetinterface to acceptnullandundefinedmatchingPropTypeassertionIconPropstype as part ofrenderIcon's assertionaria-labelas option in the main interfaceOverflowMenuPropsTesting / Reviewing