Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the DX of Elements & Icons Packages #16497

Open
3 tasks
sstrubberg opened this issue May 17, 2024 · 2 comments
Open
3 tasks

Improve the DX of Elements & Icons Packages #16497

sstrubberg opened this issue May 17, 2024 · 2 comments
Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡

Comments

@sstrubberg
Copy link
Member

sstrubberg commented May 17, 2024

User story

As a developer:

I need to: reference Carbon guidance when using elements in my project without leaving my native development environment.

so that I can: build products with less context shifting.

Additional information

REF https://marketplace.visualstudio.com/items?itemName=wzs1234566.ibm-carbon-react

Our adoption of TypeScript should cover this use-case:

code-completion

What if we had an icon preview?

hover-icon


REF https://ibm-studios.slack.com/archives/GCQ5R263T/p1714067810614929

We could utilize JSDocs to bring icon previews and color token previews into the developer's IDE.

image (7)

image (8)

Acceptance criteria

  • {{State acceptance criteria}}
  • {{State another}}
  • {{And another}}
@sstrubberg sstrubberg added type: enhancement 💡 proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels May 17, 2024
Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@sstrubberg sstrubberg changed the title Improve the DX of Elements Packages Improve the DX of Elements & Icons Packages May 17, 2024
@tay1orjones
Copy link
Member

I love this idea! Maintaining an extension seems unnecessary if we can do all this with just jsdoc. It would be good to pin down how exactly this works natively within vscode. Maybe it works because vscode uses the jsdoc markdown plugin? I'm not sure. Finding out can help determine if/where it's documented and what the possibilities or limitations are.

A few thoughts:

  • My guess is that this only works if the images are hosted externally somewhere. We can test to see if relative urls to local images and assets (svg?) can be used
  • If externally hosted images are required, the icons elements preview has all the svg's inline. So we can't link to them. We might be able to change that though?
  • Do the colors require an external link as well, or will a hex code or something work?
  • If we put all this effort into jsdoc-ing the elements packages, we could use the jsdoc github action to generate documentation pages that could be linked within the elements previews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡
Projects
Status: Triage
Development

No branches or pull requests

2 participants