Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle 4.1 testing -> Some issues found #152

Open
marxjohnson opened this issue Dec 22, 2022 · 0 comments · Fixed by #153
Open

Moodle 4.1 testing -> Some issues found #152

marxjohnson opened this issue Dec 22, 2022 · 0 comments · Fixed by #153

Comments

@marxjohnson
Copy link
Contributor

Tested on Ubuntu 22.04/PHP 8 with PostgreSQL 14 and MySQL 8.

I found the following issues:

  • Use of deprecated get_all_user_name_fields function
  • Obsolete "social" profile fields (icq, aim)

And some issues not directly related to 4.1:

  • If no users are selected by the users cleaner, the queries fail due to passing an empty string to the IN SQL conditions.
  • If all unit tests for the plugin and sub-plugins are run as a single suite, some tests fail due to the dryrun option being set in a static variable and not reset..

I also found an unrelated issue which appears to be PostgreSQL-specific, that I will log separately.
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Dec 22, 2022
@marxjohnson
[catalyst#152] tests: Prevent unit test failures when run together
9d7a24a 
Options are stored as a static class variable, so need to be reset after
tests to prevent knock-on effects on tests run after.
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Dec 22, 2022
@marxjohnson
[catalyst#152] lib: Replace deprecated user fields function
16e62b4
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Dec 22, 2022
@marxjohnson
[catalyst#152] users: Remove obsolete user profile fields
dbcfb0b
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Dec 22, 2022
@marxjohnson
[catalyst#152] users: Skip user changes if no users are selected
1fac15d
@marxjohnson marxjohnson mentioned this issue Dec 22, 2022
Merged
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Add MOODLE_311_STABLE branch to README
262c25d
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Add MOODLE_311_STABLE branch to README
21ab22c
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Bump version and supported versions
e6cbf37 
These changes only support Moodle 3.11+
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Add MOODLE_311_STABLE branch to README
18bb0be
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Update Github actions matrix for new stable branch
3f968ab
marxjohnson added a commit to marxjohnson/moodle-local_datacleaner that referenced this issue Feb 3, 2023
@marxjohnson
[catalyst#152] Update Github actions matrix for new stable branch
75c7982
danmarsden added a commit that referenced this issue Feb 6, 2023
@danmarsden
Merge pull request #155 from marxjohnson/152-update-310-readme
d445472 
[#152] Add MOODLE_311_STABLE branch to README (310 branch)
danmarsden added a commit that referenced this issue Feb 6, 2023
@danmarsden
Merge pull request #156 from marxjohnson/152-update-master-readme
0748174 
[#152] Add MOODLE_311_STABLE branch to README (master branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for Moodle 4.1 compatibility marxjohnson/moodle-local_datacleaner
1 participant
@marxjohnson