Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2659 Add warning over missing pool in save_model #2663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NickVeld
Copy link

If the concept is ok, then I can add tests if needed

Fix #2659

Before submitting a pull request, please do the following steps:

  1. Read instructions for contributors.
  2. Make sure the code builds.
  3. If you add new functionality add tests to check it.
  4. Run existing tests to make sure you haven't broken anything.
  5. If you haven't already, sign the Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model dump: JSON] model.save_model does not warn when required "pool" argument is skipped
1 participant