Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get member variable pointer at compile-time #18

Open
indianakernick opened this issue Feb 9, 2020 · 1 comment
Open

Get member variable pointer at compile-time #18

indianakernick opened this issue Feb 9, 2020 · 1 comment

Comments

@indianakernick
Copy link

visit_pointers passes the member variable pointers to the given callable. At this point, the constexpr-ness of the pointer is lost. visit_accessors passes accessor objects to the given callable. accessor has the pointer as a template parameter. I propose adding this to accessor:

static VISIT_STRUCT_CONSTEXPR auto value = ptr;

This would make it possible to access the pointer as a compile-time constant.

@indianakernick indianakernick changed the title Get member function pointer at compile-time Get member variable pointer at compile-time Feb 9, 2020
@cbeck88
Copy link
Owner

cbeck88 commented Feb 16, 2020

Hi --

Sorry I've been MIA on this library for a long time. I got married like a year and a half ago and then got super busy with other stuff and never came back to it.

I'm really glad that there are people using this library. I think your suggestion is great, I'm gonna make some time soon to read all the issues that have opened and either make PRs to try to address them or ask questions. If you want to open a PR I might also just merge it.

This library hasn't changed in a long time and there aren't any bugs afaik, so I'm not sure if it needs a more active maintainer as such, but if there's someone who wants to take over and add more stuff, especially any stuff related to new C++ features, I'm probably receptive to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants