Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silencing dbcritic issues using globs or regexes #5

Open
maartenberg opened this issue Oct 22, 2021 · 0 comments
Open

Allow silencing dbcritic issues using globs or regexes #5

maartenberg opened this issue Oct 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@maartenberg
Copy link
Member

This is a copy of a previously-internal issue.

dbcritic's issue silencing mechanism currently only allows silencing issues by specifying the exact table names.
This is a problem if there are many tables where the issue needs to be silenced (and/or these tables are dynamically created, so the name isn't known in advance).

It would be nice if we could specify the following in .dbcriticrc:

silence primary_key timeseries_agg_*

Or we could even generalize it to using regexes, if calling PCRE using the FFI is sufficiently easy (probably is):

silence primary_key /^timeseries_agg_/
@maartenberg maartenberg added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant