Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoff does not re-run tests unless there has been any other PRs merged #142

Open
AlexCELewis opened this issue Jul 22, 2022 · 0 comments
Open

Comments

@AlexCELewis
Copy link

AlexCELewis commented Jul 22, 2022

If there is a flakey test on merging you should close and reopen the PR then try to remerge the PR. This should re-run the tests and will do so if it re-joins a queue. However, if there have been no merges in-between the failed flakey test and the re-run then hoff won't try to re-run the tests because the hash of the branch is the same so running the tests again is not triggered.

The current way to get around this bug is to make a slight modification to a commit that was pushed (e.g the commit message or an empty fixup) then re-run the hoff merge.

Hoff should re-run the tests when attempting to re-merge and should not rely on other PRs being merged to change the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant