Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe against failed webhooks #98

Open
fatho opened this issue Jan 26, 2022 · 0 comments
Open

Failsafe against failed webhooks #98

fatho opened this issue Jan 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@fatho
Copy link
Member

fatho commented Jan 26, 2022

When hoff misses a webhook indicating a state change (e.g. a CI run that finished for a commit on the testing branch), PRs can just get stuck indefinitely until someone notices it and closes/reopens the PR manually.

Since webhook requests sometimes get lost in the vast voids of the internet, it would be convenient if hoff would additionally poll the GitHub API for updates, rather than relying on webhooks alone.

A good start would be polling the CI statuses of PRs that are currently being tested by hoff, since a missed webhook here can stall the queue for an indefinite amount of time. (We still would want to keep the webhook for getting prompt notifications when they work.)

Missing the webhook for a merge command is less severe, since the lack of an immediate response from the bot is already telling. A failsafe could improve UX here as well, but has less impact than one for the CI statuses. There would also be a lot more entities to poll (every open PR has the potential to receive a merge command).

@fatho fatho added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant