Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add service account creation as optional and allow podSecurityContext #4355

Open
awatterson22 opened this issue Feb 23, 2024 · 4 comments

Comments

@awatterson22
Copy link

What would you like to be added:

For helmchart, could the following fields be added?

  • In values.yaml, change the serviceAccount field to look like this:
controllerManager:
  .
  .
  serviceAccount:
    create: true
    name: chaos-controller-manager
  • In values.yaml: chaosDaemon.podSecurityContext: {}
      chaosDaemon:
        .
        .
        podSecurityPolicy: false
        podSecurityContext: {}
  • Then in helm/chaos-mesh/templates/controller-manager-deployment.yaml, change the if statement to this:
{{- if .Values.controllerManager.serviceAccount.create }}
serviceAccountName: {{ .Values.controllerManager.serviceAccount.name }}
  • Then in helm/chaos-mesh/templates/controller-manager-rbac.yaml, add the following if statement around the serviceAccount:
{{- if .Values.controllerManager.serviceAccount.create }}
.
.
.
{{- end }}

Why is this needed:

  • I would like to be able to not ignore the service account creation as I create it in another process and would like the ability to template the podSecurityContext for the chaosDaemon.
@STRRL
Copy link
Member

STRRL commented Mar 5, 2024

hi @awatterson22 , could you create a PR and help us complete it? Thanks! ❤️

@awatterson22
Copy link
Author

hi @STRRL, thank you for your reply. I have created a PR here: #4390. Just need to add my DCO and should be all set to be reviewed. Thank you!

@awatterson22
Copy link
Author

@STRRL, my PR is ready for review: #4390. Thank you

@STRRL
Copy link
Member

STRRL commented Apr 15, 2024

copy that, we would triage and review it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants