fix: add RemoteCluster cluster-wide role for controller-manager (#4417) #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-mesh#4417) Signed-off-by: Dominik Miedziński <dominik.miedzinski@allegro.com>
Signed-off-by: Dominik Miedziński <dominik.miedzinski@allegro.com>
|
Thanks! |
|
@STRRL how can we proceed with this? Integration tests are failing, but I believe it's unrelated to my change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes missing controller-manager role for RemoteClusters when clusterScoped is false.
Close #4417
What's changed and how it works?
Added
chaos-mesh.org/remoteclusterstochaos-controller-manager-cluster-levelcluster role.Related changes
UI interfaceCherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.mdTests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: