Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React warnings for using value attribute #220

Open
robbieaverill opened this issue Sep 16, 2021 · 0 comments · May be fixed by #295
Open

React warnings for using value attribute #220

robbieaverill opened this issue Sep 16, 2021 · 0 comments · May be fixed by #295
Labels
bug Something isn't working

Comments

@robbieaverill
Copy link
Contributor

In the checkout page we use set the value attribute directly on form fields without providing an onChange handler. This results in a number of React warnings in the console:

image

We should follow best practices for form field data binding. https://reactjs.org/docs/forms.html#controlled-components
@robbieaverill robbieaverill added the bug Something isn't working label Sep 16, 2021
@rortan134 rortan134 linked a pull request Jul 26, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: controlled input value warning rortan134/commercejs-nextjs-demo-store
1 participant
@robbieaverill