Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config caching changes until reload of website. #631

Open
dasbts opened this issue May 10, 2023 · 0 comments
Open

Config caching changes until reload of website. #631

dasbts opened this issue May 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dasbts
Copy link

dasbts commented May 10, 2023

Version

v0.0.98 (commit is unspecified as I build local docker image)

Description

Changing the config, then pressing close instead of save, and then reopening it appears as saved even when it is not, until the user reloads the website and opens the config again to see that the change was reverted.

To Reproduce

  1. Open the config on the top right of the website with the cogwheel button.
  2. Enter a symbol that you don't have in the list at the moment and click it so it appears in the list of symbols.
  3. Scroll to the bottom of the config and press close.
  4. Open the config on the top right again and see the change.
  5. Duplicate the tab in your browser so you have two of the website open at once.
  6. Open the config on the new duplicated tab. The change is gone, but it appears in the already opened tab.

Expected Behaviours

Clear the changes when pressing close (probably want a message if there was a change if the user really doesn't want to save the changes).

@dasbts dasbts added the bug Something isn't working label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant