Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy lint in CI #2054

Open
codetheweb opened this issue Apr 24, 2024 · 2 comments
Open

Enable mypy lint in CI #2054

codetheweb opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
cleanup good first issue Good for newcomers

Comments

@codetheweb
Copy link
Contributor

I recently enabled most of our lints in CI: #2046.

I didn't enable mypy in that PR because it looked like it required a few manual changes to pass the lint. We need to enable this lint by updating .github/workflows/chroma-lint.yml and making the appropriate changes to pass the lint (test locally with pre-commit run --all-files mypy).

@codetheweb codetheweb added good first issue Good for newcomers cleanup labels Apr 24, 2024
@ibratoev
Copy link
Contributor

ibratoev commented May 2, 2024

@codetheweb You can assign this to me. There are a ton of errors to fix. I will start opening PRs in batches to make it easier to review.

@codetheweb
Copy link
Contributor Author

awesome, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants