Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for handling error from function calls #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes for handling error from function calls #102

wants to merge 1 commit into from

Conversation

sivachandran
Copy link
Contributor

@sivachandran sivachandran commented Mar 22, 2021 •
edited

Function call errors were not handled in the implementation in multiple places. The changeset handles the error by propagating to the caller function or logging the error in error level.

The tests are run to make sure there is no functionality broken by the changes.

Addresses #98

@sivachandran sivachandran linked an issue Mar 23, 2021 that may be closed by this pull request
Make sure function errors are handled everywhere #98
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyaaank priyaaank Awaiting requested review from priyaaank

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure function errors are handled everywhere
1 participant
@sivachandran