Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On server start after a crash, call on_disconnect for all clients for whom on_connect was called in a module but on_disconnect was not called #1178

Closed
cloutiertyler opened this issue Apr 29, 2024 · 2 comments · Fixed by #1132
Closed

On server start after a crash, call on_disconnect for all clients for whom on_connect was called in a module but on_disconnect was not called #1178

cloutiertyler opened this issue Apr 29, 2024 · 2 comments · Fixed by #1132
Assignees
@kim @jdetter

Comments

@cloutiertyler
Copy link
Contributor

We could maybe get away with not having this for BitCraft Alpha, but it means that we'll have issues if the server crashes during the playtest.
@bfops bfops mentioned this issue Apr 30, 2024
Merged
1 task
@bfops bfops linked a pull request Apr 30, 2024 that will close this issue
Disconnect dangling clients #1132
Merged
1 task
@cloutiertyler
Copy link
Contributor Author

@jdetter to write a smoke test to confirm that this works

@cloutiertyler
Copy link
Contributor Author

We're no longer going to require a smoketest in order to merge. We're tracking this in a separate ticket: #1281

@kim kim closed this as completed in #1132 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kim kim

@jdetter jdetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disconnect dangling clients clockworklabs/SpacetimeDB
3 participants
@kim @jdetter @cloutiertyler