Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do apply patch not work #699

Open
yinsenyan opened this issue May 31, 2023 · 3 comments
Open

do apply patch not work #699

yinsenyan opened this issue May 31, 2023 · 3 comments
Labels
kind/bug Something isn't working
Milestone
v0.17.0

Comments

@yinsenyan
Copy link
Contributor

What happened:

Some description not patch

What you expected to happen:

Patch apply success

How to reproduce it (as minimally and precisely as possible):

  1. a crd gvk which in description not registered into k8s
  2. this crd annotation does not have original data

we will get an nil patch ({}) , but return nil

https://github.com/clusternet/clusternet/blob/main/pkg/utils/deployer.go#L610
@yinsenyan yinsenyan added the kind/bug Something isn't working label May 31, 2023
@yinsenyan
Copy link
Contributor Author

Import from #666

@dixudx dixudx added this to the v0.16.0 milestone Jun 1, 2023
@dixudx
Copy link
Member

dixudx commented Jun 1, 2023

cc @abstractmj

@abstractmj
Copy link
Contributor

@yinsenyan could you please show me the specified description data and data in member k8s?

@dixudx dixudx modified the milestones: v0.16.0, v0.17.0 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.17.0
Development

No branches or pull requests
3 participants
@dixudx @abstractmj @yinsenyan