Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ReadWriteBarrier() deprecated #76

Open
Exaelitus opened this issue Oct 6, 2020 · 2 comments
Open

_ReadWriteBarrier() deprecated #76

Exaelitus opened this issue Oct 6, 2020 · 2 comments

Comments

@Exaelitus
Copy link

FYI- Should probably replace its usage in MeowHash

https://docs.microsoft.com/en-us/cpp/intrinsics/readwritebarrier?view=vs-2019

@NoHatCoder
Copy link

And how does that work out if you want a C compatible library?

@cmuratori
Copy link
Owner

It is probably safe to just remove this entirely. It was simply an attempt to get Microsoft's codegen to do something more logical, but it is not really necessary. When I get a chance, I will be checking in explicit optimal ASM versions of Meow anyways, so there's really no need to try to have the C version produce optimal ASM anymore. Anyone who needs ASM-perfect Meow can just use the ASM files.

- Casey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants