Add integration tests for agent bootstrap scripts

[dannykopping]

The bootstrap scripts which the provisioner uses to download and run the agent are not covered by tests, as far as I can see.

This is a fairly critical area which is instrumental to the functionality of workspaces.

We should add integration tests which, as best as we can, validate that the bootstrap scripts work as expected and that agents can be brought correctly. These tests should extend to Linux, Darwin, and Windows - as each of these platforms have idiosyncratic bootstrap requirements.

coder/site/e2e/tests/createWorkspace.spec.ts

Lines 154 to 191 in a4bd50c

	test("create docker workspace", async ({ context, page }) => {
	test.skip(
	true,
	"creating docker containers is currently leaky. They are not cleaned up when the tests are over.",
	);
	requireTerraformProvisioner();
	const template = await createTemplate(page, StarterTemplates.STARTER_DOCKER);
	const workspaceName = await createWorkspace(page, template);
	// The workspace agents must be ready before we try to interact with the workspace.
	await page.waitForSelector(
	`//div[@role="status"][@data-testid="agent-status-ready"]`,
	{
	state: "visible",
	},
	);
	// Wait for the terminal button to be visible, and click it.
	const terminalButton =
	"//a[@data-testid='terminal'][normalize-space()='Terminal']";
	await page.waitForSelector(terminalButton, {
	state: "visible",
	});
	const terminal = await openTerminalWindow(
	page,
	context,
	workspaceName,
	"main",
	);
	await terminal.waitForSelector(
	`//textarea[contains(@class,"xterm-helper-textarea")]`,
	{
	state: "visible",
	},
	);
	});

is the only e2e test which seems to use the terraform provisioner, however it is skipped right now due to side-effects.

[kylecarbs]

These are tested:

coder/provisionersdk/agent_test.go

Line 31 in f149279

func TestAgentScript(t *testing.T) {

[kylecarbs]

Well, it's not for Windows at the moment, so this issue could be renamed. It tests the fetch and execution of the binary.

[dannykopping]

Testing in isolation like this is helpful, but we really need an integration test which tests the full behaviour.