Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.Editor.BlockManager.clear() should be awaited in renderFromHTML() #2641

Open
loic-bellinger opened this issue Feb 28, 2024 · 2 comments · May be fixed by #2678
Open

this.Editor.BlockManager.clear() should be awaited in renderFromHTML() #2641

loic-bellinger opened this issue Feb 28, 2024 · 2 comments · May be fixed by #2678
Labels
good first issue

Comments

@loic-bellinger
Copy link

loic-bellinger commented Feb 28, 2024 •
edited

I believe this.Editor.BlockManager.clear() should be awaited in renderFromHTML() to prevent errors.

The following example highlights the issue: data.blocks will often be empty as a result of not awaiting clear().

await $editorApi.blocks.renderFromHTML(html);
const data = await $editorApi.saver.save();
@brettearle
Copy link

Gday, can i take this on?

@neSpecc
Copy link
Member

neSpecc commented Apr 5, 2024

Gday, can i take this on?

Hello. Sure.

brettearle added a commit to brettearle/editor.js that referenced this issue Apr 5, 2024
@brettearle
codex-team#2641 await Blockmanager clear in renderFromHTML
b0734d7
This was referenced Apr 5, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added async to renderFromHTML in BlocksAPI brettearle/editor.js
3 participants
@neSpecc @loic-bellinger @brettearle