Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret for publishing signed jars must be updated #821

Open
emitc2h opened this issue Jul 21, 2022 · 3 comments
Open

Secret for publishing signed jars must be updated #821

emitc2h opened this issue Jul 21, 2022 · 3 comments

Comments

@emitc2h
Copy link
Contributor

emitc2h commented Jul 21, 2022

Following the recent sbt upgrade, the "publish signed jars" step broke cause it relies on an encrypted file travis/travis.tar extracted in travis/extract.sh which has some code in it that still relies on the old sbt. We need to either:

  • someone with the right key/iv/passphrase to decrypt the file to fix it
  • overhaul the publishing mechanism such that we don't keep encrypted secrets in the repo.

I haven't researched how to do the latter (and I may not have the time/resources), but it seems preferable in the long-term and I assume other open sources projects have figured it out.

We won't be able to make a new MLeap release until this is fixed.

@jsleight
Copy link
Contributor

@ancasarb do you know anything about this?

@ancasarb
Copy link
Member

@emitc2h @jsleight i have some idea about what's going wrong here.

i believe the issue is from this step https://github.com/combust/mleap/blob/master/travis/extract.sh and that travis.tar archive that it uses.

in the unsafe.credentials.sbt file that it generates, it likely has a first line
import com.typesafe.sbt.SbtPgp._

which looks like it should be changed to

import com.jsuereth.sbtpgp.SbtPgp._

from looking at sbt/sbt-pgp@a8c3fae

if any of you is more familiar with sbt-pgp, any help is greatly appreciated. i'll also try to understand a bit more how to fix this this week.

@ancasarb
Copy link
Member

ancasarb commented Sep 14, 2022

@emitc2h @jsleight i can share the secrets as well, if you just ping me an email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants