.execute swallows the error?

[murbanowicz]

Hi!
I am likely doing something wrong, but nothing comes obvious from the docs, unfortunately.

This is what I do in the constructor:

    this.retryPolicy = retry(
      handleWhen((err) => !(err instanceof OptimisticLockError)),
      {
        maxAttempts: configService.get('RESILIENCY_MAX_RETRIES'),
        backoff: new ExponentialBackoff(),
      },
    );

    this.circuitBreaker = ctCircuitBreaker(handleAll, {
      halfOpenAfter: configService.get('CIRCUIT_BREAKER_HALF_OPEN_AFTER'),
      breaker: new ConsecutiveBreaker(
        // +1 for the initial request. Has to be aligned with retries to get it working properly
        configService.get('RESILIENCY_MAX_RETRIES') + 1,
      ),
    });

    this.resiliencePolicy = wrap(this.retryPolicy, this.circuitBreaker);
  }

When I try to do:

  public async flush() {
    return await this.resiliencePolicy.execute(() =>
      this.repository.getEntityManager().flush(),
    );

The top level flush function is not throwing, even though the this.repository.getEntityManager().flush() is throwing, which results in completely bad behaviour of the app.

The error is basically swallowed by the execute function.

[connor4312]

The execute will either return the successful result or propagate the last error the retryPolicy encountered. If you want to observe errors thrown from the circuit breaker, or failures during the retry, you can use policy.onFailure (docs)