Push/rename image dialogs not visible #7247
Assignees
Labels
Comments
|
Found a minor fix, as suspected MessageBox could handle arbitrary placement in the html but Modal only works if the parent is most of the screen. Fix overlaps with PR #7246 so I'll wait with PR a little. |
|
The issue is still there as of podman desktop nightly (2024-05-27). |
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
May 27, 2024
PR containers#7172 moved MessageBox (which had fixed full screen positioning) to use Modal instead (which had relative positioning), which meant that any MessageBox that wasn't opened from near the root of our divs wasn't positioned correctly, and in the case of an action like Edit/rename Image at the far right, the dialog wasn't even visible on screen. Fixes containers#7247 by switching Modal to fixed positioning (copied prior styling from MessageBox). Likely also fixes a couple other cases where Modals were slightly off-centre but not enough to notice. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Sorry, prior PR merged but I didn't get this up on Friday. PR #7303 up for review now. |
feloy
pushed a commit
that referenced
this issue
May 28, 2024
PR #7172 moved MessageBox (which had fixed full screen positioning) to use Modal instead (which had relative positioning), which meant that any MessageBox that wasn't opened from near the root of our divs wasn't positioned correctly, and in the case of an action like Edit/rename Image at the far right, the dialog wasn't even visible on screen. Fixes #7247 by switching Modal to fixed positioning (copied prior styling from MessageBox). Likely also fixes a couple other cases where Modals were slightly off-centre but not enough to notice. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Something (looks like #7172) caused a regression on the Images screen. If you click the menu to push or edit an image, it doesn't appear. Looks like maybe relative position is placing it offscreen? It works from the image details screen.
Operating system
MacOS 14.5
Installation Method
None
Version
next (development version)
Steps to reproduce
No response
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: