Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ARG / passing in arguments for image building. #7250

Closed
cdrage opened this issue May 17, 2024 · 3 comments · Fixed by #7253
Closed

Support ARG / passing in arguments for image building. #7250

cdrage opened this issue May 17, 2024 · 3 comments · Fixed by #7253
Assignees
@cdrage
Labels
kind/feature 💡 Issue for requesting a new feature sprint/unplanned status/need-triage

Comments

@cdrage
Copy link
Contributor

cdrage commented May 17, 2024

Is your feature request related to a problem? Please describe

In my Containerfile I have the following:

FROM quay.io/centos-bootc/centos-bootc:stream9

# ARGUMENTS
ARG token
ARG sshpubkey

However.. I cannot using any form of argument / passing in arguments for Podman Desktop, I have to resort to using the CLI (ex: podman build -t foobar --build-arg-file build-args.conf .)

Describe the solution you'd like

We should be able to pass in argument file (under advanced section maybe?) or a ARGS to the build image section of podman desktop.

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/feature 💡 Issue for requesting a new feature label May 17, 2024
cdrage added a commit to cdrage/podman-desktop that referenced this issue May 17, 2024
@cdrage
feat: add build arguments to build page
ecb0a1d 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.
@cdrage cdrage mentioned this issue May 17, 2024
Merged
1 task
@cdrage cdrage self-assigned this May 17, 2024
cdrage added a commit to cdrage/podman-desktop that referenced this issue May 17, 2024
@cdrage
feat: add build arguments to build page
90c6f0c 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue May 17, 2024
Open
cdrage added a commit to cdrage/podman-desktop that referenced this issue May 17, 2024
@cdrage
feat: add build arguments to build page
fc78300 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage
Copy link
Contributor Author

cdrage commented May 17, 2024

FYI created during "day of learning" while diving into container builds.

cdrage added a commit to cdrage/podman-desktop that referenced this issue May 21, 2024
@cdrage
feat: add build arguments to build page
daa71e7 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue May 22, 2024
@cdrage
feat: add build arguments to build page
15bea6e 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue May 22, 2024
@cdrage
feat: add build arguments to build page
65dfabf 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@evanstoner
Copy link

Red Hat partner looking for this feature to support bootc integration. CC: @rrbanda

@cdrage
Copy link
Contributor Author

cdrage commented May 23, 2024

Red Hat partner looking for this feature to support bootc integration. CC: @rrbanda

Hi Evan! I created a PR for this that should be merged in shortly: #7253

Let me know of any other features that can help make the bootc integration more seamless, I've been doing some back-and-forth between the extension & podman desktop to see where we can improve. Thanks!

@cdrage cdrage mentioned this issue May 27, 2024
Open
cdrage added a commit that referenced this issue May 27, 2024
@cdrage
feat: add build arguments to build page (#7253)
ae38449 
### What does this PR do?

Build arguments is already built-in to podman desktop API.

This adds to the UI the ability to pass in build arguments.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes #7250

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests are covering the bug fix or the new feature

1. Build a Containerfile with ARG
2. See it fail (normal)
3. In build args, add your arg (ex. foo=bar)
4. It will now build and pass.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/feature 💡 Issue for requesting a new feature sprint/unplanned status/need-triage
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add build arguments to build page cdrage/podman-desktop
3 participants
@evanstoner @cdrage @podman-desktop-bot