Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Taxation Display Provider should respect Coreshop tax display setting #2405

Open
benwalch opened this issue Oct 23, 2023 · 5 comments

Comments

@benwalch
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

DefaultTaxationDisplayProvider should respect CoreShop setting "display prices with tax" by default.

@dpfaffenbauer
Copy link
Member

@benwalch what setting do you mean?

@benwalch
Copy link
Contributor Author

@dpfaffenbauer see PR

@dpfaffenbauer
Copy link
Member

I thought you mean that. But that is not a setting for the price display, it rather is a setting how the price is stored and calculated. Meaning that you could have a b2c site that uses net prices but still wants to display gross prices. Or a b2b site that stores gross prices but wants to show net prices

@benwalch
Copy link
Contributor Author

i see. maybe an additional setting to control the displaying prices would be nice here.

@dpfaffenbauer
Copy link
Member

Yes, maybe using CoreShop -> Settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants