Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "home brew" code to official Python client #242

Open
moshewe opened this issue Oct 3, 2021 · 6 comments
Open

Revert "home brew" code to official Python client #242

moshewe opened this issue Oct 3, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@moshewe
Copy link
Contributor

moshewe commented Oct 3, 2021

Summary

Change custom code to use the official Python API

Use Cases

It's difficult developing new features and onboarding new developers to the codebase, as the underlying structures don't follow the (well-documented) official Python API.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@moshewe moshewe added the enhancement New feature or request label Oct 3, 2021
@terrytangyuan
Copy link
Member

What do you mean by "the official Python API"?

@moshewe
Copy link
Contributor Author

moshewe commented Oct 4, 2021

@moshewe moshewe changed the title Revert "home brew" code to Python API Revert "home brew" code to official Python client Oct 4, 2021
@terrytangyuan
Copy link
Member

https://github.com/argoproj-labs/argo-client-python is unmaintained and you cannot easily support multiple versions of Argo Workflows either. We used it for validation but later removed it because there were some false positives.

@moshewe
Copy link
Contributor Author

moshewe commented Oct 6, 2021 via email

@tachyus-ryan
Copy link

@terrytangyuan
Copy link
Member

Please hold off on using https://github.com/argoproj/argo-workflows/tree/master/sdks/python until it's published to PyPI. There are still additional work to do there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants