Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is a null in when cs setup on Windows. #2843

Open
He-Pin opened this issue Sep 14, 2023 · 5 comments
Open

there is a null in when cs setup on Windows. #2843

He-Pin opened this issue Sep 14, 2023 · 5 comments

Comments

@He-Pin
Copy link

He-Pin commented Sep 14, 2023

PS C:\Users\hepin> cs setup
Checking if a JVM is installed
Found a JVM installed under C:\Users\hepin.jdks\corretto-1.8.0_382.

Checking if ~\null\Coursier\data\bin is in PATH
Should we add ~\null\Coursier\data\bin to your PATH? [Y/n]

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 14, 2023

Looks like a standard issue with powershell: dirs-dev/directories-jvm#51

@He-Pin
Copy link
Author

He-Pin commented Sep 14, 2023

@tgodzik tgodzik/metals@e4fd860 you have a pr:)

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 14, 2023

it's more of a workaround, but we could do the same in coursier

@alexarchambault
Copy link
Member

alexarchambault commented Sep 14, 2023

coursier is supposed to be using its own fork of directories-jvm, that shouldn't suffer from as many null errors as mainline directories-jvm, by getting the directories it needs using direct API calls via jni-utils. Powershell is only used as a fallback. So I wouldn't expect the exact same issue as other projects using mainline directories-jvm.

@alexarchambault
Copy link
Member

@He-Pin Do you confirm you're using the latest coursier version (2.1.7, although 2.1.5 ought to be fine)? Can you try again by setting COURSIER_JNI=force in the environment (should be set COURSIER_JNI=force), and report back what you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants