should use a well-known library to validate domain names

[aspiers]

As @juddmaltin-dell mentioned back in July, we should be using a well-known library like uri or addressable to validate domain names.

[aspiers]

crowbar/barclamp-crowbar#433 has added app/models/node.rb to the list of regexps which need to be fixed or removed.

[aspiers]

@bkutil @tboerger What do you think about this one?

[bkutil]

@bkutil @tboerger What do you think about this one?

Sure, go ahead. Addressable might do the job. Making the regexp correct & complete is hard as we'd have to consider e.g. IDNs.

[aspiers]

To clarify, I wasn't volunteering for this ;-) If as maintainers of Crowbar core you think this is worth doing then we should submit a story to the incoming board (unless it's something which can be done in 10-20 mins).

[bkutil]

Too bad :) Let's create a card and let it bubble our way. Patching itself will take a few minutes (we just need to check that all barclamps are converted), but packaging ... meh...

[tboerger]

I'm fine with that :)

[aspiers]

OK great - please link to the card from here when you create it.

[bkutil]

OK, I thought there is already an epic created for the orchestration in trello. Can you please create a card for it and add this as a task?

[aspiers]

@bkutil You lost me here - what does this have to do with orchestration? And who were you asking to create a card, and what would the story be if this was only one task in the story? Thanks.

[bkutil]

@aspiers hrm, looking back, I might have been confused and replied to some other PR than I originally intended, sorry.