Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some memo/notes section (best in configuring dialogue) [Enhancement] #651

Open
rwbc opened this issue Jan 28, 2021 · 4 comments · May be fixed by #699
Open

Add some memo/notes section (best in configuring dialogue) [Enhancement] #651

rwbc opened this issue Jan 28, 2021 · 4 comments · May be fixed by #699

Comments

@rwbc
Copy link

rwbc commented Jan 28, 2021

A suggestion

I occurred to me that it might be useful (not only for expert users) to add a little memo/notes section for installed engines.
It must not need much space and IMHO the InitStrings section is quite big anyway, thus it could have its own place while
shrinking the InitStrings window.
If it can hold 3 or 4 lines it would be quite sufficient I guess.

Here is an example with stuff it could maintain, ofc this is just plain text, which needs to be saved somewhere and will not be
sent to an engine...

cute_notes
@Oragonon
Copy link

I agree. This can be very useful.

@alwey
Copy link
Contributor

alwey commented Dec 23, 2021

Indeed.

alwey added a commit to alwey/cutechess that referenced this issue Dec 31, 2021
@alwey
Add notes to engine configurations
3fab96a 
Added m_notesEdit to EngineConfigurationDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
alwey added a commit to alwey/cutechess that referenced this issue Dec 31, 2021
@alwey
Add notes to engine configurations
c963db4 
Add QPlainTextEdit m_notesEdit to EngineConfigDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
@alwey alwey linked a pull request Dec 31, 2021 that will close this issue
Open
alwey added a commit to alwey/cutechess that referenced this issue Jan 3, 2022
@alwey
Add notes to engine configurations
25c6fb2 
Add QPlainTextEdit m_notesEdit to EngineConfigDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
alwey added a commit to alwey/cutechess that referenced this issue Jan 4, 2022
@alwey
Add notes to engine configurations
905161e 
Add QPlainTextEdit m_notesEdit to EngineConfigDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
alwey added a commit to alwey/cutechess that referenced this issue Jan 4, 2022
@alwey
Add notes to engine configurations
ff2c6db 
Add QPlainTextEdit m_notesEdit to EngineConfigDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
alwey added a commit to alwey/cutechess that referenced this issue Jan 22, 2022
@alwey
Add notes to engine configurations
ca3a98a 
Add QPlainTextEdit m_notesEdit to EngineConfigDlg
Add notes fields to EngineConfiguration and EngineConfigurationDlg

Resolves cutechess#651
@rwbc
Copy link
Author

rwbc commented Feb 1, 2022

Tested in EXPER-3 on WIN7 and it works. Notes are written to the engines.json file.

	{
		"command" : "SlowChessBlitz_27-64.exe",
		"name" : "SlowChessBlitz_27-64",
		"notes" : "- don't use syzygy with this version",
		"protocol" : "uci",
		"stderrFile" : "",
		"timeout_scale_factor" : 1,
		"workingDirectory" : "C:\\Engines\\UCI\\SlowChessBlitz_27-64"
	},
	{
		"command" : "SlowChessBlitz_28-64.exe",
		"name" : "SlowChessBlitz_28-64",
		"notes" : "- don't use syzygy with this version",
		"protocol" : "uci",
		"stderrFile" : "",
		"timeout_scale_factor" : 1,
		"workingDirectory" : "C:\\Engines\\UCI\\SlowChessBlitz_28-64"
	},

@alwey
Copy link
Contributor

alwey commented Feb 1, 2022

Great! Please make a backup copy of the engines.json file in case you are using standard cutechess again. The "notes" get deleted when a cutechess version without notes-support writes back the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add notes to engine configurations alwey/cutechess
3 participants
@alwey @rwbc @Oragonon