Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brew 4.2.20 on Mac has problem with nlohmann_json::nlohmann_json dependency #105

Closed
jackjansen opened this issue Apr 30, 2024 · 5 comments
Closed
Assignees

Comments

@jackjansen
Copy link
Contributor

Unsure when this started, but at the moment brew install cwipc sometimes fails because it cannot find nlohmann_json::nlohmann_json. Unsure why this wasn't a problem before?

@jackjansen jackjansen self-assigned this Apr 30, 2024
@jackjansen
Copy link
Contributor Author

There's an additional problem that brew install --head cwipc seems to have broken.

@jackjansen
Copy link
Contributor Author

The plot thickens. The reason nlohmann_json isn't found is that it isn't downloaded with FetchContent in the toplevel cmakefile. And the reason this doesn't happen is that in our Brew formula the cmake command gets a -DFETCHCONTENT_FULLY_DISCONNECTED=ON option. This indeed forestalls FetchContent downloading anything.

Need to find out whether I somehow did this, or it is a change in brew.

@jackjansen
Copy link
Contributor Author

Found it!

Homebrew/brew#17075 has added that option.

@jackjansen
Copy link
Contributor Author

Submitted Homebrew/brew#17187

Workaround is probably to first look for an installed version of nlohmann_json::nlohmann_json before getting a version with FetchContent, and then adding a dependency for brew.

But I'll put that off for now, so the brew maintainers can have a look at the current situation.

@jackjansen jackjansen changed the title Brew on Mac sometimes has problem with nlohmann_json::nlohmann_json Brew on Mac has problem with nlohmann_json::nlohmann_json dependency Apr 30, 2024
@jackjansen jackjansen changed the title Brew on Mac has problem with nlohmann_json::nlohmann_json dependency Brew 4.2.20 on Mac has problem with nlohmann_json::nlohmann_json dependency Apr 30, 2024
@jackjansen
Copy link
Contributor Author

Fixed in 37d69aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant