Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSI ROM Support #61

Open
rabaimorp opened this issue Mar 7, 2024 · 4 comments
Open

GSI ROM Support #61

rabaimorp opened this issue Mar 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@rabaimorp
Copy link

rabaimorp commented Mar 7, 2024

The problem:

On my samsung galaxy a53 on stock rom this app was working without problem with 5 dim levels. Than I decided to flash a GSI (specifically Lineage OS 21). This obviously changed my device's properties, causing the app to not recognise my device. If I change back the device identifiers using a root shell, or editing the build.prop this isnt the case, but that causes a bunch of other issues on my device, since I'm not using stock rom, but still having the same values.

My idea for a possible solution:

If it was possible to manually define the device within the app. (or loading a stock build.prop file from internal storage)

Or an even simpler solution: an option in the app that would automatically identify the device, even on gsi roms by looking at /vendor/build.prop (since almost all people on custom gsi roms have root anyway).

@cyb3rko cyb3rko added the enhancement New feature or request label Mar 13, 2024
@cyb3rko
Copy link
Owner

cyb3rko commented Mar 13, 2024

Thanks for the input.
Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

@rabaimorp
Copy link
Author

Thanks for the input. Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

Not necessarly. But not just for my rootless soulution idea. For testing I can recommend emulating android using Waydroid (that you can root by super easily), since testing the flashlight might not be neceassry if we only talk about custom device detection

@rabaimorp rabaimorp reopened this Apr 22, 2024
@rabaimorp
Copy link
Author

Thanks for the input. Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

Not necessarly. But not just for my rootless soulution idea. For testing I can recommend emulating android using Waydroid (that you can root by super easily), since testing the flashlight might not be neceassry if we only talk about custom device detection

@cyb3rko
Copy link
Owner

cyb3rko commented Apr 22, 2024

I've read something about Waydroid a few days ago, I will try that out when I find time for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants