Make SampleArray util method to use arrow::compute::Take
#610
Labels
Comments
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Aug 26, 2022
…te::Take and pass corresponding indices to it. Note: 1)Commented code that was deprecated by the resolution of this issue 2) Note comments in sample_binary_array function related to result status.
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Aug 27, 2022
…te::Take and pass corresponding indices to it - partial
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Aug 29, 2022
…te::Take and pass corresponding indices to it - changes from PR review
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Aug 30, 2022
…te::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array.
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Aug 31, 2022
…te::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array (continued - adds call to WrapNumericVector function added by cylondata#615-cylondata#616)
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Sep 11, 2022
…ns and remove the incorrect initialization in the constructor.
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Sep 15, 2022
mstaylor
added a commit
to mstaylor/cylon
that referenced
this issue
Sep 27, 2022
… applied google formatter per PR request. Validated tests complete successfully.
nirandaperera
added a commit
that referenced
this issue
Sep 29, 2022
#612) * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it. Note: 1)Commented code that was deprecated by the resolution of this issue 2) Note comments in sample_binary_array function related to result status. * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - partial * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from PR review * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array. * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array (continued - adds call to WrapNumericVector function added by #615-#616) * #610: move SampleTableUniform to arrow_utils and reflect changes to table.cpp * #610: correctly use reserve in vector to prevent reallocations and remove the incorrect initialization in the constructor. * #610: changes SampleTableUniform to arrow datatypes versus cylon * #610: Implements requests change to address SIG Faults. Also applied google formatter per PR request. Validated tests complete successfully. * Update arrow_utils.cpp * Update arrow_utils.hpp Co-authored-by: niranda perera <niranda.perera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we use a custom implementation for
SampleArrayutil method.We can simply replace that by using
arrow::compute::Takeand pass corresponding indices to it.The text was updated successfully, but these errors were encountered: