Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a QRCode has a non-square dimension _and_ a logotemplate, the logo draws out of location #34

Open
dagronf opened this issue Dec 15, 2023 · 2 comments
Open

If a QRCode has a non-square dimension _and_ a logotemplate, the logo draws out of location #34

dagronf opened this issue Dec 15, 2023 · 2 comments

Comments

@dagronf
Copy link
Owner

dagronf commented Dec 15, 2023

Reproduce: Build QRCodeView Demo > QRCodeView iOS Demo > Mac Catalyst and scale the window.

When you scale the window, the logo template image goes out of place. The renderer is not taking into account the QRCode offset along the longer axis.
@fontalland
Copy link

I'm just testing the library in an iPad and I'm getting the same. The mask position is great but the image goes completely out of place.

dagronf added a commit that referenced this issue Jun 8, 2024
@dagronf
Fixed bug #34 - logo drawn out of place with non-rect view
587c40c
@dagronf
Copy link
Owner Author

dagronf commented Jun 8, 2024 •
edited

Hey @fontalland, I've just pushed up a new tag (19.3.2) which should resolve this issue.

Can i ask you to check out this new version and see if it fixes the issues you've seen?

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dagronf @fontalland