Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-graphql] Add method for terminating job runs to DagsterGraphQLClient #21695

Open
garethbrickman opened this issue May 7, 2024 · 4 comments · May be fixed by #21775
Open

[dagster-graphql] Add method for terminating job runs to DagsterGraphQLClient #21695

garethbrickman opened this issue May 7, 2024 · 4 comments · May be fixed by #21775
Labels

Comments

@garethbrickman
Copy link
Contributor

garethbrickman commented May 7, 2024

What's the use case?

The GraphQL API itself has a ​terminateRun​ mutation ­documented here as well as a terminateRuns mutation that can take multiple Run IDs.

Both of these should be supported in the GraphQL Python Client.

Ideas of implementation

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@baumann-t
Copy link

Hello @garethbrickman

Just to clarify the required enhancements: The function terminate_run already exists in the client, as seen here: terminate_run function.

Would you like to add a terminate_runs function to the client that can handle multiple Run IDs simultaneously, similar to the terminateRuns mutation in the GraphQL API? If so, I'm ready to start working on this feature. Please let me know if you have any specific requirements or suggestions!

Thank you!

@garethbrickman
Copy link
Contributor Author

@baumann-t Thanks for pointing that out! I'll make a PR to update the docs to show that function is indeed available.

Would be great to work on a terminate_runs function with you! 👍

@baumann-t baumann-t linked a pull request May 10, 2024 that will close this issue
@baumann-t
Copy link

Good morning @garethbrickman, I just opened a PR for the terminate_runs function, including the unit tests: #21775

Let me know what you think!

@garethbrickman
Copy link
Contributor Author

@baumann-t Amazing thank you! Will block some time to review this next week. I'll keep you posted in the PR 👍

@garethbrickman garethbrickman linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants