Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the human-readable protocol parser to avoid memory leaks #81

Open
danielealbano opened this issue Dec 31, 2021 · 0 comments
Open
Labels
bug Something isn't working hacktoberfest hacktoberfest
Milestone

Comments

@danielealbano
Copy link
Owner

The current implementation of the human-readable Redis protocol parser is buggy as it searches for a space and then perform a number of additional operations expecting data to be present afterwards.

The bug is being triggered by the code at line

} while (arg_start_char_ptr++ && arg_start_char_ptr < buffer_end_ptr);

The test

// SECTION("multiple argument 1 byte at time, no quotes, with new line, clone data") {

triggers the issue

@danielealbano danielealbano created this issue from a note in cachegrand (Backlog) Dec 31, 2021
@danielealbano danielealbano added the bug Something isn't working label Dec 31, 2021
@danielealbano danielealbano added this to the v0.1 milestone Dec 31, 2021
@danielealbano danielealbano moved this from Backlog to Ready for Work in cachegrand Dec 31, 2021
@danielealbano danielealbano moved this from Ready for Work to In Progress in cachegrand Jun 5, 2022
@danielealbano danielealbano pinned this issue Jun 26, 2022
@danielealbano danielealbano modified the milestones: v0.1, v0.2 Jul 1, 2022
@danielealbano danielealbano moved this from In Progress to Ready for Work in cachegrand Jul 1, 2022
@danielealbano danielealbano removed this from Ready for Work in cachegrand Jul 3, 2022
@danielealbano danielealbano unpinned this issue Jul 4, 2022
@danielealbano danielealbano added the hacktoberfest hacktoberfest label Sep 12, 2022
@danielealbano danielealbano modified the milestones: v0.2, v0.3 Apr 14, 2023
@danielealbano danielealbano modified the milestones: v0.3, v0.5 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant