Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading resource_owner to be configurable. #85

Open
doomspork opened this issue Mar 17, 2021 · 1 comment
Open

Allow loading resource_owner to be configurable. #85

doomspork opened this issue Mar 17, 2021 · 1 comment

Comments

@doomspork
Copy link

Right now ExOauth2Provider relies on preload/2 to load the owner from the access token: https://github.com/danschultzer/ex_oauth2_provider/blob/master/lib/ex_oauth2_provider.ex#L92-L98

In our application this less than ideal as we need to do some additional loading alongside our user and now we're forced to maintain that logic in 2 separate parts of the app.

Would you be open to a PR that made this function optionally configurable or overrideable?

@denic
Copy link

denic commented May 21, 2021

Second that. Also I would like to add a caching layer and not hit the DB on every request.

Would be nice if we could just add a configuration option for the module that should be used to resolve the resource owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants