You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
derekxu16 opened this issue
May 10, 2024
· 5 comments
Assignees
Labels
area-pkgUsed for miscellaneous pkg/ packages not associated with specific area- teams.dds-dapDDS issues related to the Debug Adapter Protocol (DAP) implementationgardening
https://dart-review.googlesource.com/c/sdk/+/365804 should fix the drive letter mismatch (oddly that test hasn't changed in 2yrs.. not sure if the drive letter casing is somehow different on some bots for temp directory?).
Hard to tell what the other failure is - @derekxu16 is there a way to tell how frequently it's failing? We could enable verbose output on the bots temporarily to try to get a better idea of what's happening?
We have a flakiness dashboard. Unfortunately you have to log in with an @google.com account to access it, but here's a screenshot showing the run results of pkg/dds/test/dap/integration/debug_exceptions_test on Windows:
I don't know how many of these failures were caused by SocketExceptions specifically, but the test is failing frequently.
I guess many of those failures could be the drive letter issue. Let's land the fix above and then review the stats.. if there are still failures and that wasn't a one-off, I'll open a change to add verbose output and we can go from there.
(I'll ping back here a little after that fix lands)
DAP always normalises drive letters to uppercase and any tests that verify paths should do the same, otherwise tests may fail on bots where the temporary directory (where we create the test projects) happens to be created with a lowercase drive letter.
See #55685
Change-Id: I799faf4b80f3befa55ffca6bb99d28fff19101c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365804
Reviewed-by: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
A fix for the second issue (drive casing) has landed. I believe the first issue is the same as #55313 - let me know if we should close this as a dupe, or it's better to keep this open until that's also fixed (I don't know how the flaky test approval works if it might be tied to this?).
area-pkgUsed for miscellaneous pkg/ packages not associated with specific area- teams.dds-dapDDS issues related to the Debug Adapter Protocol (DAP) implementationgardening
The tests
are failing on configurations
https://dart-ci.appspot.com/log/pkg-win-release-arm64/unittest-asserts-release-win-arm64/1503/pkg/dds/test/dap/integration/debug_exceptions_test
https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-win-release-arm64/1503/overview
I see two errors in the logs. The first is a
SocketException
:The second is a drive letter capitalization mismatch:
The text was updated successfully, but these errors were encountered: